Fix a bundle of patmat issues #21000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
patmat-issues
branch
2 times, most recently
from
2ed2826 to
a2f7ecf
Compare
Some of the issues are legitimate
Previously `defn.ListType.appliedTo(elemTp) <:< pat.tpe` failed when pat.tpe is something like ParamClause, an alias.
Without that, we end up with either a flexible type or a `| Null`.
WojciechMazur
added a commit
that referenced
this pull request
Aug 28, 2024
Backports #21000 to the 3.5.2 branch. PR submitted by the release tooling. [skip ci]
This was referenced Sep 5, 2024
WojciechMazur
added a commit
that referenced
this pull request
Sep 6, 2024
WojciechMazur
added a commit
to WojciechMazur/dotty
that referenced
this pull request
Oct 9, 2024
This reverts PR scala#21000 due to introduced performance regression
WojciechMazur
added a commit
to WojciechMazur/dotty
that referenced
this pull request
Oct 9, 2024
This reverts PR scala#21000 due to introduced performance regression
WojciechMazur
added a commit
that referenced
this pull request
Oct 9, 2024
This reverts PR #21000 due to introduced performance regression
WojciechMazur
added a commit
to VirtusLab/community-build3
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the issues are legitimate.
Fixes #20121
Fixes #20122
Fixes #20123
Fixes #20128
Fixes #20129
Fixes #20130
Fixes #20131
Fixes #20132